I've been trying to use the new code reviews with my team so I'll collect some feedback here and update when I find more things:
- Initial impressions are it looks much cleaner and a step up from the built-in interface.
- I share the confusion above about Unity dashboard and separate accounts. However I can probably guess that the goal is to move everything to use this environment and deprecate the old one. If that's the case it might make sense eventually.
- What we are missing the most from GitHub pull requests and other similar systems is the ability to paste images directly into comments. This is really handy when needing to reference something visual in a game by screenshot, or show part of a visual scripting graph.
Are there any plans to add this functionality?
- We would love email notifications from code review activity like GitHub and competitors. We use plastic triggers for this currently but it's clunky, buggy and confusing. e.g. Deleting a comment currently sends a trigger to our slack with "New comment to the review 'Review Name' > Under review" which is wrong...
- It would be helpful to have some sort of "closed" state for code reviews. In some cases we've wanted to abandon the changes proposed in a code review, so "changes required" is not applicable. We also did not want to delete the code review because we want to preserve the conversation to look up in the future.
- It unfortunately feels quite slow currently, the front end is quick but it waits a very long time on the backend to do basically anything. For example, it takes about 15 seconds after a code review loads for the comments to appear.
- Bug? When the "reviewers" of a code review is set to a group, it doesn't work at all. Nobody can review it even if they are in the group.
- Bug? The "files changed" isn't actually files changed in the branch. It appears to be a straight diff of the branch against the target branch. Which means that any changes on the target branch will also show up there inversely, which doesn't seem correct. I think maybe what we should see is a dry-run merge, showing exactly what would be changed on the target branch if it were merged.
- Maybe a bug? I would like to @ mention other developers on my team in my plastic code review comment, however the list of users it suggests after typing "@" are not from my organization and I have no idea where they come from.
- Bug? The number inside the "Changed Files (n)" tab changes when you select different tabs.
- Another bug? Members of my organization can all see the same code reviews, but we cannot link code reviews to each other. The organization ID in the link is different for all of us and we all get error 403 when trying to access a link given by another team member.
- Switching to another tab in the code review discards the comment you are writing without warning. This hurts when you are writing a comment and you need to switch to another tab to see the changes and the comment is lost. With something like GitHub, the comment would be preserved when you switch back.
- This one is less technical, but with the code reviews, the "rework required" icon being a thumbs down feels a bit negative like it's saying "bad job" when in reality it mostly means "good work but please change this". I'd almost be averse to using it, as I think feedback on changes should be treated as a natural part of the process and not like something is wrong.
I hope it helps. I think there's quite a way to go still, but it's definitely in the right direction.