Jump to content

Search the Community

Showing results for tags 'code review'.

  • Search By Tags

    Type tags separated by commas.
  • Search By Author

Content Type


Forums

  • Plastic SCM
    • General
    • Installation and configuration
    • Unity 3D
    • Plastic SCM on Mac
    • Plastic SCM on Linux
    • Gluon
    • Git interop
    • Integrations
    • Community Edition
    • Branching and merging
    • Announcements
  • Plastic SCM 4.0 Beta (Closed)
  • Plastic Cloud
    • General
    • Configuration
  • SemanticMerge
    • General
    • License
    • SCM's configuration
    • Share your experience!
    • External Parsers
  • GitJungle
  • Method History for Subversion

Find results in...

Find results that contain...


Date Created

  • Start

    End


Last Updated

  • Start

    End


Filter by number of...

Joined

  • Start

    End


Group


AIM


MSN


Website URL


ICQ


Yahoo


Jabber


Skype


Location


Interests

Found 10 results

  1. Lately, we are experimenting some issues with the code reviews. We make the code reviews for entire branches and when there are multiple change requests we try to fix each one in a single check-in. This one a review with 3 change requests will have three different changesets after the one where the review was done. We've been working this way for months, and all worked fine. But, in recent versions of the client, after the first check-in closing a change request, double-clicking on the next pending change only opens the file where the comment was done. Double-clicking again navigates to the zone where the comment was done but the circle indicating the line where the comment was done does not appear and the right pane does not show the full review comment either. Clicking on the "Revision with comments", "Last in branch" or "Diff with head" does not seem to fix it either. We have tested this in the following client versions: 10.0.16.5642 10.0.16.5459 9.0.16.5242 Our server version is: 9.0.16.4507
  2. So, essentially I'm the "team lead" and one of my responsibilities is that I have to review code written by other programmers. The deal with that in Plastic is that I can't (at least I don't know how to) prevent regular programmers from changing the Code Review status. As far as I understood from the documentation, I, as a reviewer, have to manually create code reviews for task branches of other programmers. That is quite different from what I am used to in GitHub, where authors of the branch create pull requests which team leads then review. But that's another story. When it comes to GitHub, usually there's no way for authors to somehow influence the result of the pull request (their branch cannot be merged until the reviewer does that). Whereas in Plastic when either I or the author creates a Code Review on a branch, the author has an ability to change the status to "Reviewed", and therefore merge to main. To be clear, I've already set merge rule to "only allow merges when reviewed". The question is said in the title and is quite straightforward. How can I restrict changing Review status to a group of people? P.S. We use Cloud Edition.
  3. Hi, I wonder if it is possible to create a Uniform Resource Identifier (URI) to a Code Review within Plastic desktop application? My use case is that I want to be able to send code review links to my coworkers so that they can trivially locate the code review. For instance: When a user opens a URI link to a Code Review, the desktop application of Plastic SCM should open and show the Code Review as if the user manually navigated in the GUI to find the Code Review and finally opening it via double-cliking the Code Review from within the Code reviews-tab. So I am looking for something similar to how a user can open a song in Spotify via URIs, example URI: spotify:track:38uO7FeOOFoyNDFHqomxzK Is this feature available within Plastic SCM? If yes, where can I find more information about this feature?
  4. We've just started using plasticSCM for unity development with two developers and so far are generally loving it! we've run into an issue where I would make a comment on a code review, push the branch, then get a reply on that question that resolves the issue so after pulling again to see the reply, I want to delete original question, but after I delete it and push the branch, it does not get replciated on the other developers machine. the comment is still there after being deleted? is there any help someone can provide? maybe we've setup something wrong I'm not sure, but it seems like unexpected behaviour cheers
  5. Hey all, Been building a fun little tool to keep our small dev team apprised of code review events in on our discord server. Currently it's able to identify newly created code reviews, changes in status and changes in assignee. The one remaining function I'd really like to add is the addition of code review comments, but I cannot find any way to access these outside the full PlasticSCM GUI. Pretty much all the other functionality works using cm find review where ... Nothing in the "cm find" documentation suggests that looking up review comments is possible, but I'm wondering if anyone here has any ideas or knows anything that I don't. Also, this is on Plastic Cloud, so server-side triggers are not currently an option as far as I know.
  6. Hello. Is there an option to create / perform code a code review on Plastic on Linux as there is on Windows?
  7. When using the new WebUI, the code review doesn't have a word wrap feature, nor does it have a horizontal scroll bar. If it goes off the screen, the only way to be able to see it all is to expand the browser window across multiple monitors, or shrink the zoom significantly. Also, it appears that when our users insert comments - only the comments on the first files are remembered. Anything after gets lost. Is there anywhere in the config files that I can make a change to fix this?
  8. When a file is added to the repository, I can't seem to add comments to the file, only view the file. The pane below says "To add a new comment, ..." and gives directions but they don't seem to work. Is this a bug in the code review system or did I miss something?
  9. We currently use plastic in a distributed setup with local servers (pulling/pushing from each other), with a master server to manage continuous integration. We wanted to try and use the code review feature of plastic, thinking it worked similar to a pull request in git, but this does not seem to be the case. If a developer has completed his work, and creates a code review for it. I have no idea the work is done because that review does not show up in my plastic client. Can someone explain how code reviews can or should be used in a distributed environment. Right now, when a dev is done, he/she just contacts me and says can you go pull branch whatever, and review it for me. Which is not optimal for management or tracking.
  10. Hi! We have just noticed that it is impossible to add comments to a code review that only has added files. You can reproduce it easily: Create a branch, check in a new file to the branch, create a CR for the branch, open the CR and you won't be able to comment. Modify another, but existing file in the same branch and check it in, open the same CR (where you will have now an added and a changed file), you will notice that commenting is now possible. Could you please fix that? We noticed it in 5.4.16.867, but I'm sure the bug was introduced earlier. Thanks!
×
×
  • Create New...