danonBB Posted November 27, 2019 Report Share Posted November 27, 2019 I have a question about suggested workflow of doing code review for a branch changeset by changeset. Let's imagine a scenario with one branch and 2 changesets on it. When I'm reviewing changeset one how do I know if changes I'm commenting on were not modified in changeset two? Currently I'm constantly running into situation where I am making a ton of Change Requirements only to find out that most of them were already made a few changesets later. Link to comment Share on other sites More sharing options...
calbzam Posted December 3, 2019 Report Share Posted December 3, 2019 Hello, Why don't you create a code review for the full task brannch? This way, you can review all the changes at the same time and you don't need to guess if some pending changes were actually performed on a later changeset. Regards, Carlos. Link to comment Share on other sites More sharing options...
danonBB Posted December 3, 2019 Author Report Share Posted December 3, 2019 4 hours ago, calbzam said: Why don't you create a code review for the full task brannch? Because reviewing changeset by changeset is officially recommended:https://www.plasticscm.com/book/?utm_source=plasticscm-blog&utm_medium=blog-post&utm_content=thenewplasticcodereviewsystem#_checkin_often_and_keep_reviewers_in_mind Reviewing entire branch at once can be overwhelming when 70 files or so have been modified during a task Link to comment Share on other sites More sharing options...
Angew Posted December 4, 2019 Report Share Posted December 4, 2019 I normally do this by creating the review for the entire branch. Then I go through the changesets one after another, looking at each in turn. Before making a comment, I check in the [whole-]branch review whether the piece of code I'm about to comment on was changed further or not. Link to comment Share on other sites More sharing options...
danonBB Posted December 4, 2019 Author Report Share Posted December 4, 2019 @Angew That's more or less how I've been dealing with this problem but I thought there's a more convenient way I just don't know about. Honestly, simple marking lines that have been added in this changeset but altered/deleted in a later one with a different color would be very helpful Link to comment Share on other sites More sharing options...
calbzam Posted December 4, 2019 Report Share Posted December 4, 2019 We have in our roadmap to create a new panel (a third panel) that will show a diff against the head of the branch when you are performing a review changeset by changeset. For now, you can open a diff of the branch and take notes of the proposed changes so can take a look if they are already applied. Not the ultimate solution but hope it helps. Regards, Carlos. Link to comment Share on other sites More sharing options...
danonBB Posted December 5, 2019 Author Report Share Posted December 5, 2019 OK, thanks for help. And good to know that the team is on it Link to comment Share on other sites More sharing options...
Recommended Posts
Create an account or sign in to comment
You need to be a member in order to leave a comment
Create an account
Sign up for a new account in our community. It's easy!
Register a new accountSign in
Already have an account? Sign in here.
Sign In Now