Jump to content
Sign in to follow this  
danonBB

Code Review changeset by changeset

Recommended Posts

I have a question about suggested workflow of doing code review for a branch changeset by changeset. Let's imagine a scenario with one branch and 2 changesets on it. When I'm reviewing changeset one how do I know if changes I'm commenting on were not modified in changeset two? Currently I'm constantly running into situation where I am making a ton of Change Requirements only to find out that most of them were already made a few changesets later.

Share this post


Link to post
Share on other sites

Hello,

Why don't you create a code review for the full task brannch? This way, you can review all the changes at the same time and you don't need to guess if some pending changes were actually performed on a later changeset.

Regards,

Carlos.

Share this post


Link to post
Share on other sites
4 hours ago, calbzam said:

Why don't you create a code review for the full task brannch? 

Because reviewing changeset by changeset is officially recommended:
https://www.plasticscm.com/book/?utm_source=plasticscm-blog&utm_medium=blog-post&utm_content=thenewplasticcodereviewsystem#_checkin_often_and_keep_reviewers_in_mind
 

Reviewing entire branch at once can be overwhelming when 70 files or so have been modified during a task
 

Share this post


Link to post
Share on other sites

I normally do this by creating the review for the entire branch. Then I go through the changesets one after another, looking at each in turn. Before making a comment, I check in the [whole-]branch review whether the piece of code I'm about to comment on was changed further or not.

Share this post


Link to post
Share on other sites

@Angew That's more or less how I've been dealing with this problem but I thought there's a more convenient way I just don't know about. Honestly, simple marking lines that have been added in this changeset but altered/deleted in a later one with a different color would be very helpful
 

Share this post


Link to post
Share on other sites

We have in our roadmap to create a new panel (a third panel) that will show a diff against the head of the branch when you are performing a review changeset by changeset.

For now, you can open a diff of the branch and take notes of the proposed changes so can take a look if they are already applied. Not the ultimate solution but hope it helps.

Regards,

Carlos.

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
Sign in to follow this  

×
×
  • Create New...