Jump to content

Code Review - Commenting on Multiple Lines and Whole Files


Recommended Posts

Hi all,

These feel like questions that should already have answers, but I haven't been able to find anything on it through a lot of my searches. These are the questions I have:

  1. In Plastic's Code Review, is there a way to select multiple lines of a file to comment on them?

    There are times where I need to select a whole block of code to indicate a refactor must be done. Or comment on the general design of a component, which often considers multiple lines.
  2. I work with Unreal Engine, which has Blueprints (a type of node-based coding system) that are classified as binaries. I know the system won't be able to read and diff these for me, but I'd still like to annotate the file entry itself with notes. Is there a way to at least leave comments on the whole file?

    This is practical for other things too. For instance, if someone has checked in a binary file that shouldn't be there. As a reviewer, I need a way to indicate to the programmer that it shouldn't be there.
  3. Considering some of the above struggles, which comes pretty standard with other code review systems, is there a way to integrate another code review tool with Plastic?

Overall, pretty happy with the PlasticSCM experience. The Code Review tool does seem to need work, either with more functionality built-in or increased discoverability of that functionality.

Thanks!

Link to comment
Share on other sites

Hi,

Both 1. and 2. are consdiered in the design for the future code review improvements. Sorry they are not scheduled for the near future but they are very cool features.

3. Plastic has integration with ReviewBoard: https://blog.plasticscm.com/2010/03/reviewboard-integration.html

But it's a very basic integration and it has some limitations.

Regards,

Carlos.

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...