Jump to content

Code review - Requested changes incorrectly displayed


dharillo
 Share

Recommended Posts

Lately, we are experimenting some issues with the code reviews. We make the code reviews for entire branches and when there are multiple change requests we try to fix each one in a single check-in. This one a review with 3 change requests will have three different changesets after the one where the review was done.

We've been working this way for months, and all worked fine. But, in recent versions of the client, after the first check-in closing a change request, double-clicking on the next pending change only opens the file where the comment was done. Double-clicking again navigates to the zone where the comment was done but the circle indicating the line where the comment was done does not appear and the right pane does not show the full review comment either.

Clicking on the "Revision with comments", "Last in branch" or "Diff with head" does not seem to fix it either.

We have tested this in the following client versions:

  • 10.0.16.5642
  • 10.0.16.5459
  • 9.0.16.5242

Our server version is: 9.0.16.4507

Link to comment
Share on other sites

Hi @dharillo,

I assume that you are using an on-premise server. Please let me know if my assumption is incorrect.

The workflow you describe sounds like a perfectly valid one. I suspect that there is a very specific scenario which causes the Code Review to behave in this way.

Is this fairly easily reproducible? If you update your server to the latest version does the issue persist?

Link to comment
Share on other sites

Hi @ollieblanks,

Yes, we have an on-premise server.

The problem is happening to three different people and has happened in more than one review. I think it is easily reproducible.

I have already asked our IT team to check if they can update the server version to the latest version and they are going to check it.

Also, they are going to contact you at your support e-mail, linking this post if you need more detailed information that I can not share in a public forum (like screenshots where our code may be visible).

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
 Share

×
×
  • Create New...