Filter reviews by target does not work?

[JakubH]

It seems to me that the query system for reviews is broken somehow.

find reviews where targettype='changeset'

or

find reviews where targettype='changeset' and target=32874

do not filter the results. Instead, all code reviews are returned.

Am I doing something wrong?

 

Btw. what is the comment in the reviews filtering option (http://plasticscm.com/guides/cmfind/main.shtml#FilteringandOutputoptions35)?

[danipen]

Hi JakubH,

 

Thanks for your feedback. As you may imagine, we have not implemented that filter feature in the server side. So we have a missmatch between the implementation and the documentation. We are missing the following options in the implementation:

• targettype
• target
• title

We are going to update the documentation right now, and we have planned a task to fix this ASAP. We will contact you when it's ready.

Meanwhile, as a workaround you can searching by changeset, use the following:

find reviews where targetid=32874

[JakubH]

 

Meanwhile, as a workaround you can searching by changeset, use the following:

find reviews where targetid=32874

 

Interesting. I wouldn't expect this to work. I thought this would filter by a changeset > id instead of a changeset > changesetid.

Thanks.

 

Btw., it would be very helpful if the syntax like '%something%' worked for all text fields, not just a changeset comment. We would use it for a branch name and a review title very often too.