Jenkins plugin removes workspace even with Use Update flag = true

[benthroop]

Hi all,

 

I have the latest Jenkins and latest Plastic plugin for it. I am attempting to set up a Unity build machine.

 

Anyway, each time I build, the Plastic Jenkins plugin is removing the existing workspace and re-downloading it in its entirety. This is even with the "Use Update" flag set to true in the project configuration. This is not what I want as our build is capable of working incrementally and just switching to the head of /main each time we want a new build. The time difference is like 3m vs 40m. 

 

This seems like a bug. I know that it used to be a bug around v2 of the plugin, but was since fixed. 

 

Can someone help?

[benthroop]

Some other things of note:

 

- Jenkins is set to run as the currently logged in user.

- Jenkins is pointing to a custom workspace folder

- This is all on Windows 10

- My plastic installation is NOT the very latest. It is 5.4.16.681 Smoke on The Water. (We're on a slightly old one because of a bug with later versions of Unity and the Plastic plugin causing huge lag)

[calbzam]

I think that it´s broken again  We will try to fix asap, but meantime, could you try with an older plugin version?

 

The version included in this post includes a previous fix.

 

Regards,

Carlos.

[Misieq]

Hi

My Jenkins and PlasticSCM are working complately fine.

Use Update is working OK as long as I am not changeing selector value (sometimes I need to tune branch).

Could you please tell me what is the reason to delete complately workspace in such case and re-create it from scrach?

Generally it would not be a big problem except that my repo is quite big and when workspace is deleted my cloaked, ignore and hidden_change configuration is also complately removed

Especially that in GUI I am switching between branches and even repositories and/or server and there is no need to re-create workspace.

Thanks in advance for the answer.

[Misieq]

Hi

Any comments for my question?

Thanks in advance.

[manu]

Hi!

 

we are able to reproduce the issue and we are going to be fixing it asap, hopefully today.

 

I'll update this thread once the bugfix is public.

[Misieq]

Hi

I have noticed new Jenkins plugin version (2.5)with some corrections around "Use Update".

So checked again behaviour with parametrized selectors and workspace deletion...

It looks that the issue is still present

I went quickly through plugin code (at GitHub) and this is what I have found:

PlasticSCM.checkout(...) -> PlasticSCM.isWorkspaceDeleteNeeded -> workspaceConfiguration.equals(...) -> builder.append(this.selector, other.selector);

So it looks that in fact any change in selector will always lead to Workspace deletion and re-creation from the scrach...

Do you plan to change this behaviour? Or at least please do not delete conf files (cloaked, hidden_changes and ignore).

[manu]

Hello Misieq,

 

the issue is in our issue tracking system and we'll try to get it done asap.

 

I'll keep this thread posted with any progress we make.

[manu]

Oooooooorrrrrrrrrrrrrrrrrrrrrrrr

 

 

you can give a try to the GitServer feature of the latest Plastic SCM server.... connect Jenkins to Plastic via Git and that should do the trick  

 

plasticscm.com/gitserver

[Misieq]

I would like to

But my company is not able to upgrade server due to some issue - as far as I know administators already have contacted with Codice and you work on solution.

PS. GitServer has one restriction which is pretty problematic - lack of authentication and security.

I would propose (as first step) to add option to be able to configure Git access as ReadOnly.

[manu]

Hi Misieq,

 

please ask the admins to send a reminder, can't see pending issues from "compower".

 

Regarding GitServer configuration, what do you miss from the documentation, did you read this guide? https://www.plasticscm.com/documentation/gitserver/plastic-scm-version-control-gitserver-guide.shtml

 

And yes, right now the service is not having security or RO access, I really like the last one and should be easy to get done, you are kindly requested to add the idea here:  https://plasticscm.uservoice.com/forums/15467-general

[Misieq]

Hi

Compower is not my company address but private.

So I really doubt if my ISP even knows about Codice

But admins from my company are pinged by me from time to time so I am quite sure that they did not forget about upgrade.

Regarding guide I went through.

That is why I mentioned restriction which bothers me the most.

PS. Idea posted: https://plasticscm.uservoice.com/forums/15467-general/suggestions/13783221-configurable-read-only-access-for-gitserver

[Wodzu]

Hi,

 

I am completely new around here I don't know if my issue is the same as Misieq's (I don't know what the "selector" is) but I've also noticed that Jenkins plugin is deleting one of PlasticSCM workspaces even if there were no changes to the workspace. I've run one build after another and I've noticed this behaviour. Here is part of the Jenkins log:

[CommonLib] $ "c:\Program Files\PlasticSCM5\client\cm.exe" rmwk wk:CommonLib\
The workspace CommonLib\ has been deleted.
[CommonLib] $ "c:\Program Files\PlasticSCM5\client\cm.exe" mkwk CommonLib\ . --selector=selector849559857143387732.txt
Workspace CommonLib\ has been correctly created
[CommonLib] $ "c:\Program Files\PlasticSCM5\client\cm.exe" update .

My plugin version is 2.5 and of course I have "update" turned on.

[calbzam]

Hi,

 

We have recently release the 2.6 version including a fix.

 

https://wiki.jenkins-ci.org/display/JENKINS/PlasticSCM+Plugin

 

Could you upgrade and check if the issue is reproducible?

 

Regards,

Carlos.

[Misieq]

Hello Carlos

 

You mean that 2.6 shall fixed behaviour with deletion of workspace in case of parametrized selector?

 

It is not mentioned in Change Log.

Moreover I checked on GitHub and in classes I spotted there are no changes in this area.

 

Or maybe you was answering only for Wodzu's post.

If so could you please tell me when do you plan to work on "parametrized selector" issue (and Pipeline workflow approach mentioned here: http://www.plasticscm.net/index.php?/topic/3468-jenkins-plasticscm-compatibility-with-pipelines-workflows/). Thanks in advance for any info.

[manu]

Hi Misieq,

 

we changed the way the selector is parsed so we don't force unneeded updates operations. Not sure if it's your case but it's worth to try it out.

 

https://github.com/jenkinsci/plasticscm-plugin/commit/3749e47129a95dd1ce85766953dd65d12bd40047

 

 

Can you give it a try and give us feedback? If it keeps failing we'll schedule internal test to give you a fix.

[Misieq]

Hi

 

I will.

Latest on Monday you can expect feedback.

[manu]

Great! thanks.

[Misieq]

Hello

I have checked it with newest version of plugin.

It still behaves in the same way.

As previously in build log following line appears:

Deleting workspace as the configuration has changed since the last build on this computer.

I am still thinking that "path" which I pointed in one of the previous posts is the main root cause of such behaviour.

[manu]

Thank you for the feedback.

 

Let me start a few tests and I'll try to get more info.

[manu]

I'm sorry but I can't reproduce the issue.

Can you tell me if you osee the same behavior after creating a new Jenkinks project? This is what I get after creating a brand new one:

Started by an SCM change
Building in workspace C:\Program Files (x86)\Jenkins\workspace\TestingPlasticSCMPlugin
[ZZZ_Wks] $ cm lwk --format={0}#{1}#{2}
ZZZ_Wks#SUPERAWESOMECOM#c:\Program Files (x86)\Jenkins\workspace\TestingPlasticSCMPlugin\ZZZ_Wks
[ZZZ_Wks] $ cm ss wk:ZZZ_Wks
Selector for workspace ZZZ_Wks:
repository "ZZZ@localhost:8087"  path "/"    smartbranch "/Production"

[ZZZ_Wks] $ cm update "c:\Program Files (x86)\Jenkins\workspace\TestingPlasticSCMPlugin\ZZZ_Wks"
Downloading big file c:\Program Files (x86)\Jenkins\workspace\TestingPlasticSCMPlugin\ZZZ_Wks\trigger.txt (12 bytes)
Copied c:\Program Files (x86)\Jenkins\workspace\TestingPlasticSCMPlugin\ZZZ_Wks\trigger.txt
[ZZZ_Wks] $ cm wi "c:\Program Files (x86)\Jenkins\workspace\TestingPlasticSCMPlugin\ZZZ_Wks" --machinereadable --fieldseparator=def#_#sep
BRdef#_#sep/Productiondef#_#sepZZZ@localhost:8087
[ZZZ_Wks] $ cm find changeset where date between '2016-09-07T12:49:13' and '2016-09-07T12:57:08' and branch='/Production' on repositories 'ZZZ@localhost:8087' --xml --dateformat=yyyy'-'MM'-'dd'T'HH':'mm':'ss
<?xml version="1.0" encoding="utf-8" ?>
<PLASTICQUERY>
  <CHANGESET>
    <ID>50325</ID>
    <CHANGESETID>313</CHANGESETID>
    <COMMENT></COMMENT>
    <DATE>2016-09-07T12:55:42</DATE>
    <OWNER>mlucio</OWNER>
    <REPOSITORY>ZZZ</REPOSITORY>
    <REPNAME>ZZZ</REPNAME>
    <REPSERVER>localhost:8087</REPSERVER>
    <BRANCH>/Production</BRANCH>
    <PARENT>312</PARENT>
    <GUID>5cfb81dd-ef47-4cc4-8d57-04c256f87bc8</GUID>
  </CHANGESET>
</PLASTICQUERY>
[ZZZ_Wks] $ cm gwp "c:\Program Files (x86)\Jenkins\workspace\TestingPlasticSCMPlugin\ZZZ_Wks" --format={1}
c:\Program Files (x86)\Jenkins\workspace\TestingPlasticSCMPlugin\ZZZ_Wks
[ZZZ_Wks] $ cm diff cs:313@ZZZ@localhost:8087 --format={path}#@_sep_@#{revid}#@_sep_@#{parentrevid} --repositorypaths
"/trigger.txt"#@_sep_@#50321#@_sep_@#50315
Finished: SUCCESS

It's a build triggered by a new change in the repository, only one file is downloaded and the workspace is preserved.

[Misieq]

Hi

I think you did not catch exactly my use case.

I am using PARAMETRIZED SELECTOR.
 
So my Jenkins Job has following configuration:
 
1) String Parameter named branch added with default value "/main"
2) Selector defined as:

repository "<repository>@<server>:8087"
path "/"
smartbranch "%branch%"

 
 
First build (with branch parameter set to /main) of this job (when no workspace is yet created) generates following output (behaviour correct):

Building in workspace c:\j\workspace\Tutorial
[tutorial] $ cm lwk --format={0}#{1}#{2}
[tutorial] $ cm mkwk tutorial c:\j\workspace\Tutorial\tutorial --selector=c:\j\workspace\Tutorial\tutorial\selector4578542194289647674.txt
Workspace tutorial has been correctly created
[tutorial] $ cm update c:\j\workspace\Tutorial\tutorial

 
Second build (again with branch parameter set to /main) - behaviour is correct (workspace is only updated not recreated):

Building in workspace c:\j\workspace\Tutorial
[tutorial] $ cm lwk --format={0}#{1}#{2}
tutorial#DL1T3B5Y1#c:\j\workspace\Tutorial\tutorial
[tutorial] $ cm ss wk:tutorial
Selector for workspace tutorial:
repository "tutorial@uskoaa37.northamerica.delphiauto.net:8087"	path "/"		smartbranch "/main"

[tutorial] $ cm update c:\j\workspace\Tutorial\tutorial

 
Third build (this time I have changed branch parameter value to /main/j_TUT-210) - workspace is recreated (behaviour is not correct).

Building in workspace c:\j\workspace\Tutorial
Deleting workspace as the configuration has changed since the last build on this computer.
[tutorial] $ cm lwk --format={0}#{1}#{2}
tutorial#DL1T3B5Y1#c:\j\workspace\Tutorial\tutorial
[tutorial] $ cm rmwk wk:tutorial
The workspace tutorial has been deleted.
[tutorial] $ cm mkwk tutorial c:\j\workspace\Tutorial\tutorial --selector=c:\j\workspace\Tutorial\tutorial\selector5342539367101548308.txt
Workspace tutorial has been correctly created
[tutorial] $ cm update c:\j\workspace\Tutorial\tutorial

[manu]

I'm sorry, I didn't pay enough attention to your post.

 

I'm afraid I can reproduce the issue using parametrized selectors, the system is not able to determine that the repository is still the same and just run an update operation.

 

I'll share this with the team and I'll give you an update asap.

[Misieq]

I think that formally system does not need to determine if repository and/or server is the same.

 

As far as I recall with GUI it is possible to just switch workspace to any repo on any server, isn't it?

So maybe it would be just enough to check (in case of "use update") that physical path and name of workspace is still the same as for previous build.

[manu]

Yes,

 

we'll find the best way to get it fixed.